GH-211: handle non-existent retry listeners #393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssjf409 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ssjf409 Thank you for signing the Contributor License Agreement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Guys.
I wanted to handle GH-211 issue, and @artembilan gave me a good suggestion. I came up with two ways and was preparing two different PRs.
The first is to literally ignore all listeners when the
listenersattribute is set to"".The second is that when the
listenersattribute is set to a non-existent listener, it will have the same effect as a listener without any configuration.The first implementation seems to have been implemented nicely by akenra in this PR. So, I'm posting a PR for the second implementation as well.