Fix wrong ProgressView ctor use

- Fixes a bug so that given items are actually used - Relates #995
spring-projects · Feb 16, 2024 · d38d0d4 · d38d0d4
1 parent 77a6948
commit d38d0d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/...ell-core/src/main/java/org/springframework/shell/component/view/control/ProgressView.java b/...ell-core/src/main/java/org/springframework/shell/component/view/control/ProgressView.java
@@ -137,8 +137,7 @@ public ProgressView(int tickStart, int tickEnd) {
 	 * @param items the progress view items
 	 */
 	public ProgressView(ProgressViewItem... items) {
-		this(0, 100, new ProgressViewItem[] { ProgressViewItem.ofText(), ProgressViewItem.ofSpinner(),
-				ProgressViewItem.ofPercent() });
+		this(0, 100, items);
 	}
 
 	/**

diff --git a/...ore/src/test/java/org/springframework/shell/component/view/control/ProgressViewTests.java b/...ore/src/test/java/org/springframework/shell/component/view/control/ProgressViewTests.java
@@ -61,6 +61,12 @@ void constructJustText() {
 			assertThat(getViewItems(view)).hasSize(1);
 		}
 
+		@Test
+		void constructJustTextJustItems() {
+			view = new ProgressView(ProgressViewItem.ofText());
+			assertThat(getViewItems(view)).hasSize(1);
+		}
+
 	}
 
 	@Nested