Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringInput better unicode handling #1115

Closed
jvalkeal opened this issue Aug 13, 2024 · 0 comments
Closed

StringInput better unicode handling #1115

jvalkeal opened this issue Aug 13, 2024 · 0 comments
Labels
branch/3.2.x Issue for a branch branch/3.3.x Issue for a branch for/backport For backporting type/enhancement Is an enhancement request
Milestone
3.4.0-M1

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Aug 13, 2024 •
edited
Loading

Non-english characters are not bound when using StringInput. For new view system this was done in #845 but was never added to older flow components. Should mimic what was done there.

There's still going to be issues with Grapheme Clusters which some asian characters are using and are traditionally difficult to support in terminals. There's an old issue #841 for this.

Also looking on which versions to backport this.
@jvalkeal jvalkeal added the type/enhancement Is an enhancement request label Aug 13, 2024
@jvalkeal jvalkeal added this to the 3.4.0-M1 milestone Aug 13, 2024
@jvalkeal jvalkeal added for/backport For backporting branch/3.2.x Issue for a branch branch/3.3.x Issue for a branch labels Aug 13, 2024
This was referenced Aug 13, 2024
Closed
Closed
jvalkeal added a commit that referenced this issue Aug 13, 2024
@jvalkeal
StringInput better unicode handling
b519005 
- Add unicode handling in flow components in
  AbstractTextComponent which allows StringInput
  to process unicode given from jline.
- This add basic non-english character support
  for input.
- Backport #1115
- Fixes #1117
jvalkeal added a commit that referenced this issue Aug 13, 2024
@jvalkeal
StringInput better unicode handling
1dbb35a 
- Add unicode handling in flow components in
  AbstractTextComponent which allows StringInput
  to process unicode given from jline.
- This add basic non-english character support
  for input.
- Backport #1115
- Fixes #1116
@jvalkeal jvalkeal mentioned this issue Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/3.2.x Issue for a branch branch/3.3.x Issue for a branch for/backport For backporting type/enhancement Is an enhancement request
Projects
None yet
Milestone
3.4.0-M1
Development

No branches or pull requests
1 participant
@jvalkeal