Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind all keys in view framework #823

Open
Tracked by #761
jvalkeal opened this issue Jul 22, 2023 · 0 comments
Open
Tracked by #761

Bind all keys in view framework #823

jvalkeal opened this issue Jul 22, 2023 · 0 comments
Labels
area/components-view Belongs ui view components
Milestone
3.3.x

Comments

@jvalkeal
Copy link
Contributor

Current trouble with jline is that if you don't bind a key in its BindingReader we use, things get through into a shell and may mess up terminal itself.

We bind keys in our KeyBinder which currently just binds subset of available options. Short term we should bind all available keys. Other work to consider is to bypass BindingReader and do things manually.
@jvalkeal jvalkeal added the area/components-view Belongs ui view components label Jul 22, 2023
@jvalkeal jvalkeal added this to the 3.2.x milestone Jul 22, 2023
@jvalkeal jvalkeal mentioned this issue Jul 22, 2023
Open
19 tasks
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Aug 10, 2023
@jvalkeal
Initial hotkey infra
7391d0d 
- Duplicate keyhandler into hotkeyhandler
- Define some view to handle hot keys, like AppView and MenuBarView
- Catalog app binds some menus to hot keys
- Bind all normal keys a-z with alt
- Relates spring-projects#823
- Relates spring-projects#826
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Sep 9, 2023
@jvalkeal
Add missing ascii keys to KeyEvent
a679de0 
- Relates spring-projects#823
@jvalkeal jvalkeal modified the milestones: 3.2.x, 3.3.x Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/components-view Belongs ui view components
Projects
None yet
Milestone
3.3.x
Development

No branches or pull requests
1 participant
@jvalkeal