Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements equals and hash code overrides for completion proposal #244

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jphughes88
Copy link

Added with @georgiacarr1999

@pivotal-issuemaster
Copy link

@jphughes88 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@jphughes88 Thank you for signing the Contributor License Agreement!

@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #244 into master will decrease coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #244      +/-   ##
============================================
- Coverage     48.91%   48.88%   -0.03%     
- Complexity      252      255       +3     
============================================
  Files            53       53              
  Lines          1333     1342       +9     
  Branches        204      210       +6     
============================================
+ Hits            652      656       +4     
+ Misses          625      623       -2     
- Partials         56       63       +7
Impacted Files Coverage Δ Complexity Δ
.../org/springframework/shell/CompletionProposal.java 51.72% <22.22%> (-3.28%) 8 <2> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec5899...089d7c3. Read the comment docs.

@stephen-murby
Copy link

@ericbottard Wonder if you could help with this PR, wondering about the coverage. Is it usual for you to write tests against POJO's or should the class be added to an exclusion list?

If you are not the right person, firstly, apologies, secondly are you able to point us in the right direction? I wasn't able to find any contributing docs with an IRC or slack channel etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants