Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate spring-faces to Jakarta EE #1794

Closed
wants to merge 1 commit into from
Closed

Migrate spring-faces to Jakarta EE #1794

wants to merge 1 commit into from

Conversation

liptga
Copy link

@liptga liptga commented Feb 1, 2023

1793 - upgrading spring-faces to use jakarta ee
729509c 
- FlowResourceResolver.java is removed, since was deprecated - see jakartaee/faces#1583
@rstoyanchev rstoyanchev self-assigned this Feb 1, 2023
@rstoyanchev rstoyanchev linked an issue Feb 1, 2023 that may be closed by this pull request
Spring Faces migration to Jakarta EE #1793
Closed
@rstoyanchev rstoyanchev changed the title 1793 - upgrading spring-faces to use jakarta ee Migrate spring-faces to Jakarta EE Feb 2, 2023
@rstoyanchev rstoyanchev removed a link to an issue Feb 2, 2023
Spring Faces migration to Jakarta EE #1793
Closed
@rstoyanchev rstoyanchev added this to the 3.0.0-RC1 milestone Mar 27, 2023
@rstoyanchev rstoyanchev mentioned this pull request Mar 27, 2023
Closed
@rstoyanchev rstoyanchev linked an issue Mar 27, 2023 that may be closed by this pull request
Spring Faces migration to Jakarta EE #1793
Closed
rstoyanchev
rstoyanchev approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and apologies for the delay. Overall looks good and tests pass. Have you tried it with a sample or application yet? I'm wondering if the changes to all the constants work as expected.

rstoyanchev pushed a commit that referenced this pull request Mar 27, 2023
@rstoyanchev
Update spring-faces to Jakarta EE
bce7f0c 
FlowResourceResolver.java is removed, since it was deprecated, see
jakartaee/faces#1583

See gh-1794
rstoyanchev added a commit that referenced this pull request Mar 27, 2023
@rstoyanchev
Update dependencies
5b27250 
See gh-1794
rstoyanchev added a commit that referenced this pull request Mar 27, 2023
@rstoyanchev
Remove RichFaces checks
43dc24a 
See gh-1794
@liptga
Copy link
Author

liptga commented Mar 27, 2023 •
edited
Loading

Have you tried it with a sample or application yet?

@rstoyanchev We have migrated our framework on Spring Boot 3 and Jakarta EE 10, and we used also this patched version of Spring-faces. All of our unit tests are passing with this changeset, and our demo UI app also works as expected. However it could be surely tested deeper by others. Maybe a release candidate could be built and published, and then lets see if it also works for others.

@rstoyanchev rstoyanchev mentioned this pull request Mar 27, 2023
Closed
@rstoyanchev
Copy link
Contributor

Good to know, thanks. I plan to update our own samples in #1795, and we could definitely also use further feedback from other applications.

@keith-h
Copy link

keith-h commented Jul 11, 2023

When is 3.0.0 due to be released?

@rstoyanchev
Copy link
Contributor

It is released now.

@martin654
Copy link

@rstoyanchev Hi, we are migrating our app to Spring Boot 3.1 and Jakarta EE10 these days, what a challanging task. But, SpringWebflow version 3.0.0 looks really good! I haven't found any issue so far. Many thanks for this major upgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev rstoyanchev approved these changes

Assignees

@rstoyanchev rstoyanchev

Labels
in: integration type: enhancement
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Spring Faces migration to Jakarta EE
4 participants
@liptga @rstoyanchev @keith-h @martin654