Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

live hover for @ConditionalOnProperty doesn't work for Boot 3.x #1410

Closed
martinlippert opened this issue Nov 15, 2024 · 2 comments
Closed

live hover for @ConditionalOnProperty doesn't work for Boot 3.x #1410

martinlippert opened this issue Nov 15, 2024 · 2 comments
Assignees
@martinlippert
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: live-data type: bug
Milestone
4.27.0.RELEASE

Comments

@martinlippert
Copy link
Member

@ConditionalOnProperty produces a live hover with information about the property evaluation when using Spring Boot 2.7.
This doesn't work with Sprig Boot 3.x and needs fixing.
@martinlippert martinlippert added type: bug for: eclipse something that is specific for Eclipse theme: live-data for: vscode something that is specific for VSCode labels Nov 15, 2024
@martinlippert martinlippert added this to the 4.27.0.RELEASE milestone Nov 15, 2024
@martinlippert martinlippert self-assigned this Nov 15, 2024
@martinlippert
Copy link
Member Author

There are actually two problems behind the scenes, one is specific for Spring Boot 3.x, the other one causes this feature to not even work for Spring Boot 2.x apps.

martinlippert added a commit that referenced this issue Nov 17, 2024
@martinlippert
GH-1410: adopt new jmx method from boot 3 apps to fetch the condition…
b4292f6 
… report and deal correctly with conditions embedded in app node
@martinlippert
Copy link
Member Author

Fixed with b4292f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinlippert martinlippert

Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: live-data type: bug
Projects
None yet
Milestone
4.27.0.RELEASE
Development

No branches or pull requests
1 participant
@martinlippert