Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Yarn installation info #11

Merged
merged 2 commits into from
Mar 6, 2018
Merged

Add more Yarn installation info #11

merged 2 commits into from
Mar 6, 2018

Conversation

sonniesedge
Copy link

@sonniesedge sonniesedge commented Mar 6, 2018

Add a quick addition based upon installing this package on a real Yarn environment.

Copy link
Contributor

@josebolos josebolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this change, the point of using npx is to avoid installing install-peerdeps as it's something that you're only going to use once. I'm also not a fan of installing things globally as it's prone to break very easily.

I wonder if there's a way of doing with yarn the same thing that npx does (running a command without actually installing it)?

(I'm not familiar with yarn, I have to say)

@sonniesedge
Copy link
Author

sonniesedge commented Mar 6, 2018

I'd advocate adding it as one of many options. We're already showing a install-peerdeps option in https://github.com/springernature/eslint-config-springernature/blame/master/README.md#L52

I agree that we shouldn't force a global install on users of the package - that's very naughty. But showing an optional quick/automated installation method using a global package - I can't see a fundamental problem with that.

I'll take a look and see if there's also a npx-ish way of doing things with Yarn.

@sonniesedge
Copy link
Author

Hmmm, interestingly, there's no direct equivalent of npx in Yarn. The nearest is the create command, which isn't that useful here I think.

@josebolos
Copy link
Contributor

josebolos commented Mar 6, 2018

How about just using npx? From what I can get that npx does, I don't think that using yarn to install deps prevents us from using npx.

From your link:

npx performs no operations which clash with people using other package managers. It doesn't even require npm to be on the system, so you can npm rm -g npm and npx will work just fine.

@sonniesedge
Copy link
Author

Back from lunch. Hallo! I agree with that npx could be easily used in this case. 👍 I've updated the PR to reflect that. What do you think?

Copy link
Contributor

@josebolos josebolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazeballs 🥇

@sonniesedge
Copy link
Author

Hurrah!

@sonniesedge sonniesedge merged commit fd489cc into master Mar 6, 2018
@sonniesedge sonniesedge deleted the add-more-yarn-info branch March 6, 2018 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants