Disable sketchy-null check for strings

springload · Jan 13, 2019 · 8c8da38 · 8c8da38
1 parent 17e3c3e
commit 8c8da38
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.flowconfig b/.flowconfig
@@ -12,6 +12,7 @@ suppress_comment= \\(.\\|\n\\)*\\$FlowFixMe
 
 [lints]
 all=error
+sketchy-null-string=off
 
 [options]
 module.name_mapper='.*\(.scss\)' -> 'empty/object'

diff --git a/examples/sources/EmbedSource.js b/examples/sources/EmbedSource.js
@@ -77,7 +77,7 @@ class EmbedSource extends Component<Props, State> {
       `${EMBEDLY_ENDPOINT}&url=${encodeURIComponent(url)}`,
       null,
       (embed) => {
-        if (entity && entityKey !== null && typeof entityKey !== "undefined") {
+        if (entity && entityKey) {
           const nextContent = content.mergeEntityData(entityKey, {
             url: embed.url,
             title: embed.title,

diff --git a/examples/sources/ImageSource.js b/examples/sources/ImageSource.js
@@ -58,7 +58,7 @@ class ImageSource extends Component<Props, State> {
 
     e.preventDefault();
 
-    if (entity && entityKey !== null && typeof entityKey !== "undefined") {
+    if (entity && entityKey) {
       const nextContent = content.mergeEntityData(entityKey, { src });
       nextState = EditorState.push(editorState, nextContent, "apply-entity");
     } else {