This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Aleo docs #66
Merged
Aleo docs #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clehner
reviewed
Jan 27, 2022
clehner
reviewed
Jan 27, 2022
clehner
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
LGTM. Shows what is implemented in spruceid/ssi#348 + spruceid/ssi#360. Minor change suggestions.
Co-authored-by: Charles E. Lehner <cel@celehner.com>
Co-authored-by: Charles E. Lehner <cel@celehner.com>
|
Thanks for the corrections! |
clehner
approved these changes
Jan 28, 2022
wyc
reviewed
Jan 28, 2022
|
Good work, LGTM. Requested one change only. |
Co-authored-by: wyc <wyc@fastmail.fm>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the aleo docs @wyc requested I work on. My editor auto-formatted some files but semantically nothing should have changed.
I've added some extra notes regarding how this should be built (as currently it depends on spruceid/ssi#348 and spruceid/ssi#360 and didkit-cli with the necessary feature
ssi/aleosig).