Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/demo/dev ai integrations #2831

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bohdanyevtukhov
Copy link

PR Description

TBD

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@bohdanyevtukhov bohdanyevtukhov self-assigned this Sep 25, 2024
Copy link
Contributor

@ilyakubanov ilyakubanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add ticket to the PR description

@@ -0,0 +1,83 @@
This document describes how to install the [OpenAi]() feature.
Copy link
Contributor

@ilyakubanov ilyakubanov Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This document describes how to install the [OpenAi]() feature.
This document describes how to install the OpenAi feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe Open AI feature will be better? If agree please apply to all the places in all the files


## Install feature core <!-- Skip if there won't be a frontend section in the doc -->

Follow the steps below to install the {Feature Name} feature core.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature name is not added


Follow the steps below to install the {Feature Name} feature core.

### Prerequisites
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are the Prerequisites?

### Prerequisites

### 1) Install the required modules

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Run the following command to install the required module: before

```

**Verification**
<!--Describe how a developer can check they have completed the step correctly.-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all the comments in all the files

Comment on lines +119 to +120
**src/Pyz/Zed/Product/ProductDependencyProvider.php**
```php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

Comment on lines +112 to +117
| ProductCategoryProductAbstractPostCreatePlugin | Adds action on product abstract post create event. | | SprykerEco\Yves\ImageSearchAi\Plugin\Router |
| ProductCategoryProductAbstractAfterUpdatePlugin | Adds action on product abstract after update event. | | SprykerEco\Yves\ImageSearchAi\Plugin\Router |
| ProductCategoryAbstractFormExpanderPlugin | Expands `ProductAbstractForm`. | | SprykerEco\Yves\ImageSearchAi\Plugin\Router |
| ImageAltTextProductConcreteEditFormExpanderPlugin | Expands `ProductConcreteEditForm` with `alt_text` field. | | SprykerEco\Yves\ImageSearchAi\Plugin\Router |
| ImageAltTextProductAbstractFormExpanderPlugin | Expands `ProductAbstractForm` with `alt_text` field. | | SprykerEco\Yves\ImageSearchAi\Plugin\Router |
| ImageAltTextProductConcreteFormExpanderPlugin | Expands `ProductConcreteForm` with `alt_text` field. | | SprykerEco\Yves\ImageSearchAi\Plugin\Router |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why SprykerEco\Yves\ImageSearchAi\Plugin\Router? These plugins are not routers

protected function getProductAbstractPostCreatePlugins(): array
{
return [
...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
...

Remove everywhere

}
```

**src/Pyz/Zed/ProductManagement/Presentation/Add/index.twig**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same related to all the FE changes, not clear what it is, why it is needed, etc

{% endraw %}
```

To apply the changes, run the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply changes sounds not correct, please describe properly what this command does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants