Merge pull request #226 from spsanderson/development

Fixes #222
spsanderson · Jan 25, 2024 · 15834c6 · 15834c6
2 parents 36bbaef + 5a51750
commit 15834c6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -5,9 +5,12 @@ None
 
 ## New Features
 1. Fix #217 - Add plotting function for `extract_regression_residuals()`
+2. Fix #215 - Add plotting function for `extract_wflw_predictions()`
 
 ## Minor Fixes and Improvements
 1. Fix #214 - Drop selection message from `load_deps()`
+2. Fix #222 - Update `fast_regression()` and `fast_classification()` to drop NULL
+predictions.
 
 # tidyAML 0.0.4
 

diff --git a/R/make-classification-fast.R b/R/make-classification-fast.R
@@ -101,6 +101,7 @@ fast_classification <- function(.data, .rec_obj, .parsnip_fns = "all",
 
   if (.drop_na){
     mod_pred_tbl <- mod_pred_tbl[!sapply(mod_pred_tbl$fitted_wflw, function(x) length(x) == 0), ]
+    mod_pred_tbl <- mod_pred_tbl[!sapply(mod_pred_tbl$pred_wflw, function(x) length(x) == 0), ]
   }
 
   # Return ----

diff --git a/R/make-regression-fast.R b/R/make-regression-fast.R
@@ -92,6 +92,7 @@ fast_regression <- function(.data, .rec_obj, .parsnip_fns = "all",
 
   if (.drop_na){
     mod_pred_tbl <- mod_pred_tbl[!sapply(mod_pred_tbl$fitted_wflw, function(x) length(x) == 0), ]
+    mod_pred_tbl <- mod_pred_tbl[!sapply(mod_pred_tbl$pred_wflw, function(x) length(x) == 0), ]
   }
 
   # Return ----