Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies to Suggests: #147

Closed
HenrikBengtsson opened this issue May 26, 2023 · 2 comments
Closed

Add dependencies to Suggests: #147

HenrikBengtsson opened this issue May 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@HenrikBengtsson
Copy link

I saw your Fediverse post. Regardless of decision, I think you should declare all those extra package dependencies:

core_packages <- function(){
c(
"multilevelmod","rules","poissonreg","censored","baguette","bonsai",
"brulee","rstanarm","dbarts","kknn","ranger","randomForest",
"LiblineaR","flexsurv","gee","glmnet"
)
}

under Suggests: in your DESCRIPTION file, if there's code in your package that depends on them.

My $.02

@spsanderson
Copy link
Owner

spsanderson commented May 27, 2023 via email

@HenrikBengtsson
Copy link
Author

HenrikBengtsson commented May 27, 2023

A common expectation is that if you install a package and all of its declared dependencies, including suggested ones, then everything in the packages works. You should not have to install additional packages beyond this. This also makes reverse packages checks possible plus more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants