Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

PR: Cleaning up code #94

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

PR: Cleaning up code #94

wants to merge 10 commits into from

Commits on Sep 21, 2016

  1. Remove mutable default values

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    2929e1c View commit details
    Browse the repository at this point in the history

  2. Avoid None as redundant second argument to dict.get()

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    7a0053d View commit details
    Browse the repository at this point in the history

  3. Replace list by generator

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    c62ebfe View commit details
    Browse the repository at this point in the history

  4. Replace lambdas by nested functions

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    bd5bf43 View commit details
    Browse the repository at this point in the history

  5. Avoid using to check if a list is empty

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    6f2bc48 View commit details
    Browse the repository at this point in the history

  6. Avoid unnecessary name repetition in equality comparisions

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    acb4f8e View commit details
    Browse the repository at this point in the history

  7. Add license code and use format instead of %

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    4d6f7d8 View commit details
    Browse the repository at this point in the history

  8. Use format instead of %

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    7699178 View commit details
    Browse the repository at this point in the history

  9. Use static methods when needed

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    6597a9a View commit details
    Browse the repository at this point in the history

  10. Avoid consecutive ifs

    @goanpeca
    goanpeca committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    b884363 View commit details
    Browse the repository at this point in the history