-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Feature/add state handling #43
Conversation
@SylvainCorlay we kind of need this urgently, any chance you get to review today? |
Hi Gonzalo, I can look at it tonight but if you really need it merged now to iterate, Cheers, S. @SylvainCorlay https://github.com/SylvainCorlay we kind of need this — |
@SylvainCorlay what happen with I can take a look at it later tonight 😆?, its ok, been there as well, right @Nodd? Anyway, we are using our own icons (svg) directly, so this change is no longer critical... still I would appreciate if you took some time to review it as this covers an important use case. Thanks 😸 |
Hi I am travelling this week so I won't be able to look at it right away. If you are confident, you can go ahead and merge. Regarding the svg icons, is it something you think should/could be integrated in the spyder font? |
Nope this is very specific to the application we are developing and not related to Spyder. |
import json | ||
import os | ||
|
||
# Third party importd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in "importd"
I addressed all @Nodd's comments, so I'm merging :-) |
PR: Feature/add state handling
This PR completes the expected behavior of icons, which include the possibility of a State (On, Off)
Added new example to illustrate usage.