PR: Remove Qt4 support #252
Conversation
jschueller
force-pushed
the
rip_qt4
branch
2 times, most recently
from
99b43f2 to
021edfd
Compare
There was a problem hiding this comment.
Thanks for all the work @jschueller ! I left some comments in files where there are still some references to PyQt4 and/or PySide (mostly in docstrings or file descriptions).
Besides that, some logic related to PyQt4 still remains at test_main.py and conftest.py.
Also, we need to check the patch for QComboBox (qcombobox.py and test_patch_combobox.py) which maybe should be removed since from the test definition segfaults in PySide2/PySide6 and partially for PyQt5.
Regarding the QComboBox patch what do you think @ccordoba12 ?
I agree, I think we should remove it. |
|
ok, I removed that patch and its test in the sources |
There was a problem hiding this comment.
Thanks @jschueller for the changes ! I was checking again and I left a comment in compat.py regarding the _qfiledialog_wrapper
After that I think this should be ready to be merged 👍
Although. just in case, what do you think @ccordoba ?
Looks good to me, so I'd also say it's ready for merge (except for your last comment, of course). |
Closes spyder-ide#70
Removes Pyside and PyQt4 support (its not even tested anymore), Qt5 is way more common nowadays and we have support for Qt6 (PySide6, and preliminary work for PyQt6)