PR: Add workaround for mode argument in QTextCursor.movePosition (Pyside2)
#341
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on() PySide2 does not accept the `mode` keyword argument in QTextCursor.movePosition() even though it is a valid optional argument as per C++ API. Fix this by monkeypatching. Notes: * The `mode` argument is called `arg__2` in PySide2 as per QTextCursor.movePosition.__doc__ and __signature__. Using `arg__2` as keyword argument works as intended, so does using a positional argument. Tested with PySide2 5.15.0, 5.15.2.1 and 5.15.3; older version, down to PySide 1, are probably affected as well [1]. * PySide2 5.15.0 and 5.15.2.1 silently ignore invalid keyword arguments, i.e. passing the `mode` keyword argument has no effect and doesn’t raise an exception. Older versions, down to PySide 1, are probably affected as well [1]. PySide2 5.15.3 raises an exception when `mode`or any other invalid keyword argument is passed. [1] https://bugreports.qt.io/browse/PYSIDE-185
ccordoba12
changed the title
mode argument in QTextCursor.movePosition()mode argument in QTextCursor.movePosition (Pyside2)
dalthviz
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Thanks @rear1019 for helping with this! LGTM 👍
Also, maybe could be worthy to open an issue over PySide @ccordoba12 @rear1019 ? The only one I found related to this is closed: https://bugreports.qt.io/browse/PYSIDE-185
I'm not sure they're still accepting bug reports against PySide2 since they've stopped providing LTS for open source users, but it could potentially be patched in the PySide2 conda packages. |
|
PySide6 is affected as well. At the very least, one gets an exception as with PySide2 >= 5.15.3 |
|
Please open a pull request to patch Pyside6 as well. |
rear1019
added a commit
to procitec/spyder
that referenced
this pull request
Sep 22, 2022
* Arguments are called differently than they are in C++ interface * PySide2 < 5.15.3 doesn’t raise an exception for unknown kwarg * Also see [1] for a similar issue [1] spyder-ide/qtpy#341
rear1019
added a commit
to procitec/spyder
that referenced
this pull request
Sep 23, 2022
* Arguments are called differently than they are in C++ interface * PySide2 < 5.15.3 doesn’t raise an exception for unknown kwarg * Also see [1] for a similar issue [1] spyder-ide/qtpy#341
rear1019
added a commit
to procitec/spyder
that referenced
this pull request
Oct 4, 2022
* Arguments are called differently than they are in C++ interface * PySide2 < 5.15.3 doesn’t raise an exception for unknown kwarg * Also see [1] for a similar issue [1] spyder-ide/qtpy#341
rear1019
added a commit
to procitec/spyder
that referenced
this pull request
Apr 3, 2023
The argument “[hv]Policy” is called “[hv]Data” in PySide2 and PySide2<5.15.3 doesn’t raise an exception for invalid keyword arguments (also see [1]). [1] spyder-ide/qtpy#341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message/comment in code for details.