Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix PyQt6 typing import for Qt #358

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

tlambert03
Copy link
Contributor

small fix that allows IDEs to find QtCore.Qt in PyQt6

@ccordoba12 ccordoba12 changed the title fix pyqt6 typing import for Qt PR: Fix pyqt6 typing import for Qt Jul 24, 2022
@ccordoba12 ccordoba12 added this to the v2.2.0 milestone Jul 24, 2022
@ccordoba12 ccordoba12 requested a review from dalthviz July 24, 2022 01:19
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small style comment, otherwise LGTM at least.

qtpy/QtCore.py Outdated Show resolved Hide resolved
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tlambert03 . @dalthviz ?

@CAM-Gerlach CAM-Gerlach changed the title PR: Fix pyqt6 typing import for Qt PR: Fix PyQt6 typing import for Qt Jul 24, 2022
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlambert03 !

@dalthviz dalthviz merged commit 469e8d1 into spyder-ide:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants