Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update coveralls config (CI) #428

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

dalthviz
Copy link
Member

Fixes #426

@dalthviz dalthviz added this to the v2.4.0 milestone Apr 14, 2023
@dalthviz dalthviz self-assigned this Apr 14, 2023
@dalthviz dalthviz changed the title [WIP] PR: Remove basedir flag for coverage command (CI) [WIP] PR: Update basedir flag for coverage command (CI) Apr 14, 2023
@dalthviz dalthviz changed the title [WIP] PR: Update basedir flag for coverage command (CI) [WIP] PR: Update coveralls command config (CI) Apr 14, 2023
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dalthviz dalthviz modified the milestones: v2.4.0, v2.4.1 Aug 11, 2023
@dalthviz dalthviz modified the milestones: v2.4.1, v2.4.2 Oct 16, 2023
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@dalthviz dalthviz marked this pull request as ready for review October 27, 2023 22:25
@dalthviz dalthviz changed the title [WIP] PR: Update coveralls command config (CI) PR: Update coveralls config (CI) Oct 27, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@dalthviz
Copy link
Member Author

dalthviz commented Nov 1, 2023

Is okay if we merge this one @CAM-Gerlach ? Or do you think something is missing?

@dalthviz
Copy link
Member Author

dalthviz commented Nov 3, 2023

Going ahead and merging this. However, if there are things that needed to be further worked on, let me know

@dalthviz dalthviz merged commit 865fb47 into spyder-ide:master Nov 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coveralls config needs to be updated
3 participants