Apply suggestions from code review

installers-conda/build-environment.yml

@@ -9,6 +9,6 @@ dependencies:
   - constructor =3.8.1
   - gitpython
   - mamba
-  - menuinst =2.1.1
+  - menuinst =2.1.0
   - ruamel.yaml.jinja2
   - setuptools_scm

spyder/plugins/updatemanager/widgets/update.py

@@ -130,6 +130,7 @@ def __init__(self, parent):
         self.download_thread = None
         self.download_worker = None
         self.progress_dialog = None
+        self.installer_dir = None
         self.installer_paths = None
 
     # ---- General
@@ -257,9 +258,11 @@ def _set_installer_paths(self):
                 'runtime': {'file': f'conda-runtime-{plat}-{mach}.lock'},
             }
 
-        dirname = osp.join(get_temp_dir(), 'updates', self.latest_release)
+        self.installer_dir = osp.join(
+            get_temp_dir(), 'updates', self.latest_release
+        )
         for v in self.installer_paths.values():
-            v['file'] = osp.join(dirname, v['file'])  # Full path
+            v['file'] = osp.join(self.installer_dir, v['file'])  # Full path
             v['size'] = osp.splitext(v['file'])[0] + '-size'  # Add size file
 
     # ---- Download Update
@@ -332,7 +335,7 @@ def _start_download(self):
         self.progress_dialog = None
 
         self.download_worker = WorkerDownloadInstaller(
-            self.latest_release, self.installer_paths
+            self.latest_release, self.installer_dir, self.installer_paths
         )
 
         self.sig_disable_actions.emit(True)

spyder/plugins/updatemanager/workers.py

@@ -229,18 +229,15 @@ class WorkerDownloadInstaller(BaseWorker):
         Total size of the file expected to be downloaded.
     """
 
-    def __init__(self, latest_release, installer_paths):
+    def __init__(self, latest_release, installer_dir, installer_paths):
         super().__init__()
         self.latest_release = latest_release
+        self.installer_dir = installer_dir
         self.installer_paths = installer_paths
         self.error = None
         self.cancelled = False
         self.paused = False
 
-        self.installer_dir = osp.dirname(
-            next(iter(installer_paths.values()))['file']
-        )
-
     def _progress_reporter(self, progress, total_size):
         """Calculate download progress and notify."""
         self.sig_download_progress.emit(progress, total_size)
@@ -255,6 +252,11 @@ def _download_installer(self):
         """Donwload Spyder installer."""
         os.makedirs(self.installer_dir, exist_ok=True)
 
+        # self.installer_paths is a dictionary of download types: "installer"
+        # or "base" and "runtime". Each download type is a dictionary of
+        # string paths: "file" is the download destination and "size" is the
+        # file in which to store the size of the downloaded file for
+        # verification.
         for v in self.installer_paths.values():
             url = (
                 "https://github.com/spyder-ide/spyder/releases/download/"