Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check update process for 6.0.2 with a rc (6.0.2rc1) #22685

Closed
ccordoba12 opened this issue Oct 17, 2024 · 8 comments
Closed

Check update process for 6.0.2 with a rc (6.0.2rc1) #22685

ccordoba12 opened this issue Oct 17, 2024 · 8 comments

Comments

@ccordoba12
Copy link
Member

ccordoba12 commented Oct 17, 2024

Given that the changes in PR #22598 are not so simple, I think we should manually check the update process is working as expected.

For that, I propose the following:

  • With the nightly installers for the day before, click on the Check for updates... menu entry after the 6.0.2rc1 Github release is published but before the installers are generated. This should give no error and offer no update either.
  • After the installers are uploaded, and also using the nightly installers, check the update process between them and rc1 is working.

@mrclary, are there other checks you think we should run before releasing 6.0.2?

@ccordoba12 ccordoba12 added this to the v6.0.2 milestone Oct 17, 2024
@mrclary
Copy link
Contributor

mrclary commented Oct 17, 2024

@ccordoba12, I think that is the best we can do. I don't think anything else needs to be tested.

I think that we'll need to coordinate our check for update with the Github release since we will have a short time window in which to test it:

  • Linux: < 5min
  • macOS: ~8-12min
  • Windows: ~27min

Perhaps a zoom/discord call? If everyone installs the latest nightly before the call, then we can be ready to test the check-for-update as soon as @dalthviz publishes the release while on the call.

@ccordoba12
Copy link
Member Author

Perhaps a zoom/discord call? If everyone installs the latest nightly before the call, then we can be ready to test the check-for-update as soon as @dalthviz publishes the release while on the call.

Agreed, that's a good idea. What do you think @dalthviz?

@dalthviz
Copy link
Member

Sure 👍

@dalthviz dalthviz changed the title Check update process for 6.0.2 Check update process for 6.0.2 with an rc (6.0.2rc1) Oct 29, 2024
@dalthviz dalthviz changed the title Check update process for 6.0.2 with an rc (6.0.2rc1) Check update process for 6.0.2 with a rc (6.0.2rc1) Oct 29, 2024
@dalthviz dalthviz mentioned this issue Oct 29, 2024
5 tasks
@dalthviz
Copy link
Member

Just in case 6.0.2rc1 is now available over PyPI (https://pypi.org/project/spyder/6.0.2rc1/) and also created the PR to update the conda-forge recipe (conda-forge/spyder-feedstock#195)

@dalthviz
Copy link
Member

So GitHub release for 6.0.2rc1 was created (https://github.com/spyder-ide/spyder/releases/tag/v6.0.2rc1) and manual testing for the improvements to the update mechanism were successful 🎉 So I would say this should be closed now, right @ccordoba12 @mrclary ?

@mrclary
Copy link
Contributor

mrclary commented Oct 30, 2024

I'm double-checking the update process, so standby...

@mrclary
Copy link
Contributor

mrclary commented Oct 30, 2024

Okay, everything looks good on my end. rc1 updated successfully.

@ccordoba12
Copy link
Member Author

ccordoba12 commented Oct 30, 2024

I can confirm that the update proceeded without problems on Linux too.

@dalthviz, could you check that on Windows? If things are working as expected, then close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants