PR: Check for asset availability when checking for updates #22598

mrclary · 2024-09-27T20:22:27Z

Description of Changes

Check that the download asset is available before alerting the user to an available update. If the asset is not available, also check the next-latest release, and so on, until either no update or no asset is available.
Use osascript in order not to pollute shell history on macOS.
Ensure UpdateWorker.channel is assigned.

Issue(s) Resolved

Fixes #22566
Fixes #22572

ccordoba12

Initial review for you @mrclary.

spyder/plugins/updatemanager/tests/test_update_manager.py

spyder/plugins/updatemanager/workers.py

spyder/plugins/updatemanager/widgets/update.py

spyder/plugins/updatemanager/tests/test_update_manager.py

pep8speaks · 2024-10-15T00:35:56Z

Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/updatemanager/workers.py:

Line 235:80: E501 line too long (83 > 79 characters)

Comment last updated at 2024-10-16 16:39:19 UTC

mrclary · 2024-10-15T00:38:23Z

Initial review for you @mrclary.

@ccordoba12, thank you for suggesting the TypedDict 👍🏼

ccordoba12

Second round of suggestions for you @mrclary, then this should be ready (you can add them to the commit where you addressed my initial review, if you want).

spyder/plugins/updatemanager/workers.py

…o an available update. Create a function that determines the asset name, update type, and url, depending on the latest release and the current Spyder version. Fixes spyder-ide#22566

Fixes spyder-ide#22572

…WorkerDownloadInstaller.latest_release are now packaging.version.Version objects instead of strings. We can now use packaging.version mechanisms for comparison, sorting, and stable release checks.

…ailable.

Added test_update_no_asset and test_get_asset_info

ccordoba12

Last nitpick @mrclary.

spyder/plugins/updatemanager/workers.py

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>

ccordoba12

Looks good to me now, thanks @mrclary!

ccordoba12 · 2024-10-16T18:24:38Z

@meeseeksdev please backport to 6.x

lumberbot-app · 2024-10-16T18:24:51Z

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

git checkout 6.x
git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 f9dfab7ac825489a86103cfce8c8d80788daa413

You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #22598: PR: Check for asset availability when checking for updates'

Push to a named branch:

git push YOURFORK 6.x:auto-backport-of-pr-22598-on-6.x

Create a PR against branch 6.x, I would have named this PR:

"Backport PR #22598 on branch 6.x (PR: Check for asset availability when checking for updates)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

…hecking for updates

…en checking for updates) (#22684)

mrclary changed the title ~~PR: Update manager~~ PR: Check for asset availability when checking for update Sep 27, 2024

mrclary force-pushed the update-manager branch from f53e4ad to 78fef01 Compare September 28, 2024 03:48

ccordoba12 added this to the v6.0.2 milestone Sep 29, 2024

ccordoba12 assigned mrclary Sep 29, 2024

ccordoba12 added type:Bug Installers component:Update manager labels Sep 29, 2024

mrclary force-pushed the update-manager branch 2 times, most recently from 379eced to b2da67c Compare October 1, 2024 19:50

mrclary requested a review from ccordoba12 October 4, 2024 06:17

mrclary force-pushed the update-manager branch 3 times, most recently from 68153cd to a0ec21a Compare October 10, 2024 20:20

mrclary force-pushed the update-manager branch 2 times, most recently from b558ba3 to 6552f65 Compare October 14, 2024 21:37

ccordoba12 reviewed Oct 14, 2024

View reviewed changes

mrclary force-pushed the update-manager branch from dde2b0c to bfdca46 Compare October 15, 2024 03:31

ccordoba12 reviewed Oct 15, 2024

View reviewed changes

mrclary added 6 commits October 15, 2024 10:23

Check that the download asset is available before alerting the user t…

c4ae944

…o an available update. Create a function that determines the asset name, update type, and url, depending on the latest release and the current Spyder version. Fixes spyder-ide#22566

Use osascript in order not to pollute shell history on macOS

071f474

Set WorkerUpdate.channel to pypi if Spyder is not installed by conda.

cc1fa00

Fixes spyder-ide#22572

UpdateManagerWidget.latest_release, WorkerUpdate.latest_release, and …

6a40570

…WorkerDownloadInstaller.latest_release are now packaging.version.Version objects instead of strings. We can now use packaging.version mechanisms for comparison, sorting, and stable release checks.

Check previous releases for available asset if latest asset is not av…

7e51ec2

…ailable.

Update tests.

96e6863

Added test_update_no_asset and test_get_asset_info

mrclary force-pushed the update-manager branch 2 times, most recently from 31b13da to c171a8c Compare October 15, 2024 18:47

ccordoba12 reviewed Oct 16, 2024

View reviewed changes

spyder/plugins/updatemanager/workers.py Outdated Show resolved Hide resolved

Apply suggestions from code review

24e8366

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>

mrclary force-pushed the update-manager branch from c171a8c to 24e8366 Compare October 16, 2024 16:39

ccordoba12 approved these changes Oct 16, 2024

View reviewed changes

ccordoba12 changed the title ~~PR: Check for asset availability when checking for update~~ PR: Check for asset availability when checking for updates Oct 16, 2024

ccordoba12 merged commit f9dfab7 into spyder-ide:master Oct 16, 2024
17 checks passed

lumberbot-app bot added the Still Needs Manual Backport label Oct 16, 2024

ccordoba12 added a commit to ccordoba12/spyder that referenced this pull request Oct 17, 2024

Backport PR spyder-ide#22598: PR: Check for asset availability when c…

762db28

…hecking for updates

ccordoba12 removed the Still Needs Manual Backport label Oct 17, 2024

ccordoba12 mentioned this pull request Oct 17, 2024

Check update process for 6.0.2 with a rc (6.0.2rc1) #22685

Closed

mrclary deleted the update-manager branch October 17, 2024 01:50

ccordoba12 added a commit that referenced this pull request Oct 17, 2024

Backport PR #22598 on branch 6.x (PR: Check for asset availability wh…

9074047

…en checking for updates) (#22684)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Check for asset availability when checking for updates #22598

PR: Check for asset availability when checking for updates #22598

mrclary commented Sep 27, 2024 •

edited

Loading

ccordoba12 left a comment

pep8speaks commented Oct 15, 2024 •

edited

Loading

mrclary commented Oct 15, 2024

ccordoba12 left a comment

ccordoba12 left a comment

ccordoba12 left a comment

ccordoba12 commented Oct 16, 2024

lumberbot-app bot commented Oct 16, 2024

PR: Check for asset availability when checking for updates #22598

PR: Check for asset availability when checking for updates #22598

Conversation

mrclary commented Sep 27, 2024 • edited Loading

Description of Changes

Issue(s) Resolved

ccordoba12 left a comment

Choose a reason for hiding this comment

pep8speaks commented Oct 15, 2024 • edited Loading

Comment last updated at 2024-10-16 16:39:19 UTC

mrclary commented Oct 15, 2024

ccordoba12 left a comment

Choose a reason for hiding this comment

ccordoba12 left a comment

Choose a reason for hiding this comment

ccordoba12 left a comment

Choose a reason for hiding this comment

ccordoba12 commented Oct 16, 2024

lumberbot-app bot commented Oct 16, 2024

mrclary commented Sep 27, 2024 •

edited

Loading

pep8speaks commented Oct 15, 2024 •

edited

Loading