Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PR: Print frames deadlock #10461

Closed
wants to merge 3 commits into from

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Oct 19, 2019

Description of Changes

This allows printing the current frames even in case of a deadlock.

For example, run:

from qtpy.QtCore import QMutex
lock = QMutex()
lock.lock()
lock.lock()

This creates a deadlock in c code. Pressing ctrl + c won't help you. This can give helpful insight to debug the issue.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Screenshot 2019-10-19 at 09 59 40

Issue(s) Resolved

(kind of) Fixes #1613

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: impact27

@impact27
Copy link
Contributor Author

this helps mitigate ipython/ipykernel#449

@impact27 impact27 force-pushed the print_frames_deadlock branch from 4060680 to 9265047 Compare October 20, 2019 16:47
@impact27 impact27 changed the title [Depends on #10438] Print frames deadlock Print frames deadlock Nov 1, 2019
@impact27 impact27 changed the title Print frames deadlock PR: Print frames deadlock Nov 1, 2019
@impact27 impact27 changed the title PR: Print frames deadlock [WIP] PR: Print frames deadlock Nov 16, 2019
@impact27
Copy link
Contributor Author

I have added [WIP] because this needs a way of filtering out spyder code from the frames.

@goanpeca goanpeca added this to the 4.1.0 milestone Nov 30, 2019
@impact27
Copy link
Contributor Author

I am not sure this is going to be for Spyder 4. I think we should keep this for spyder 5

@goanpeca goanpeca modified the milestones: 4.1.0, v5.0beta1 Nov 30, 2019
Quentin Peter added 3 commits December 27, 2019 09:33
use shell instead of client


fix
@impact27 impact27 force-pushed the print_frames_deadlock branch from 8869d0c to a472efd Compare December 27, 2019 08:36
@impact27
Copy link
Contributor Author

replaced by #11186

@impact27 impact27 closed this Dec 27, 2019
@ccordoba12 ccordoba12 removed this from the v5.0beta1 milestone Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual debug call stack window - enhacement request
3 participants