Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Create conda-based application installer for macOS and Linux #19461

Merged
merged 43 commits into from
Oct 20, 2022
Merged

PR: Create conda-based application installer for macOS and Linux #19461

merged 43 commits into from
Oct 20, 2022

Commits on Oct 19, 2022

  1. Create experimental macOS package installer. 

    Adapted from napari/napari-packaging
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    24ef24c View commit details
    Browse the repository at this point in the history

  2. Use white background for pkg logo

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0c30c8a View commit details
    Browse the repository at this point in the history

  3. Update installer licensing and branding

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c65c5a4 View commit details
    Browse the repository at this point in the history

  4. Eliminate spyder-menu feedstock. 

    - Remove spyder-menu spec
- Add commands for menuinst files to conda build script
- Set menu_packages to spyder package name
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0d51ff1 View commit details
    Browse the repository at this point in the history

  5. Use conda-forge feedstock

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    59d6a00 View commit details
    Browse the repository at this point in the history

  6. Some cleanup

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    1449ac3 View commit details
    Browse the repository at this point in the history

  7. Add script for building conda packages

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    17ecfbb View commit details
    Browse the repository at this point in the history

  8. Rename directory

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    50e3bb3 View commit details
    Browse the repository at this point in the history

  9. Add spyder source code patch

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c32cfe8 View commit details
    Browse the repository at this point in the history

  10. Cleanup

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    f87a3c8 View commit details
    Browse the repository at this point in the history

  11. Add timers

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    79a839f View commit details
    Browse the repository at this point in the history

  12. Add logger

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    43031a7 View commit details
    Browse the repository at this point in the history

  13. Use setuptools_scm instead of git init 

    - Use scm for python-lsp-server
- Clone remote python-lsp-server (shallow), unless user specifies source via environment variable
- Do not git init the other external-deps
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    50f2f06 View commit details
    Browse the repository at this point in the history

  14. Add script for notarizing

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0205384 View commit details
    Browse the repository at this point in the history

  15. Add script for creating keychain on CI

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ca798a7 View commit details
    Browse the repository at this point in the history

  16. Add github workflow

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    475decb View commit details
    Browse the repository at this point in the history

  17. Update workflow paths to ignore installers-conda directory for unit t… 

    …ests and other installers
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    878e8f9 View commit details
    Browse the repository at this point in the history

  18. Update patch file

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    4a26d61 View commit details
    Browse the repository at this point in the history

  19. Fix PermissionError 

    - Put feedstock build.sh patch into separate file and apply only for posix platforms.
- Build executable in build.sh patch
- Allow user's shell to be determined at runtime instead of install time.
- Set SPYDER_APP to runtime location of app bundle
- Compile application executable for macOS at conda package build time. Requires shc
- Post install script moves compiled executable to correct location and patches Info.plist

Note that Spyder.sh must be compiled before or at conda-build; referenced install-time dependent variables must be included in LSEnvironment.
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    052d03e View commit details
    Browse the repository at this point in the history

  20. Make certificate id an argument rather than environment variable

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    78a03fe View commit details
    Browse the repository at this point in the history

  21. Only move codesign if creating keychain. Ensure only signing on relea… 

    …se (secrets not available on forked branch PRs). Fix build package logic
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0885d0e View commit details
    Browse the repository at this point in the history

  22. Explicitly use spyder and subrepo versions for build specs 

    - Get shallow repo for all external-deps
- Provide environment variable for alternative source for all external-deps
- Use scm to get version for all repos
- Write all specs to specs.yaml, used by installer
- Alternative environment activation in application executable provides accurate environment variables; find environment root conda/mamba
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    390e53b View commit details
    Browse the repository at this point in the history

  23. Test matrix workflow

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    8bcdb65 View commit details
    Browse the repository at this point in the history

  24. Adjust matrix 

    - Fix matrix.platform
- Fix python-version for some matrix elements
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ad21ca0 View commit details
    Browse the repository at this point in the history

  25. Fix list of files to untar

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    25f65fa View commit details
    Browse the repository at this point in the history

  26. Restore build steps

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    509886a View commit details
    Browse the repository at this point in the history

  27. Revise specs handling 

    - Always explicitly specify spyder version
- Only add spec relation when specs file is read
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    36cf00a View commit details
    Browse the repository at this point in the history

  28. Refactor matrix jobs: noarch conda builds, followed by platform depen… 

    …dent builds (conda and installer)
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    1f57fd0 View commit details
    Browse the repository at this point in the history

  29. Provide function to change file permissions. This is required for Win… 

    …dows in order to remove some .git files.
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    875f8d3 View commit details
    Browse the repository at this point in the history

  30. Patch bld.bat

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    99a0a88 View commit details
    Browse the repository at this point in the history

  31. Remove tests from outputs

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    6d636ea View commit details
    Browse the repository at this point in the history

  32. Remove superfluous treatment of patches

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    316cc78 View commit details
    Browse the repository at this point in the history

  33. Fix icon_image specification

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    bd2832b View commit details
    Browse the repository at this point in the history

  34. Add linux and windows platforms

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    b2194f5 View commit details
    Browse the repository at this point in the history

  35. tar's -C does not work properly for windows so we must change directo… 

    …ries manually
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    7a60068 View commit details
    Browse the repository at this point in the history

  36. Set CONDA_BLD_PATH to shorter path than default to avoid "FileNotFoun… 

    …dError: [WinError 206] The filename or extension is too long" on Windows
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    2b80340 View commit details
    Browse the repository at this point in the history

  37. Include scientific packages 

    - Include lite option for package installer
- include paramiko and pyxdg
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    40b80c6 View commit details
    Browse the repository at this point in the history

  38. Remove win-64 from matrix build for release. Restore after release.

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    6ffa416 View commit details
    Browse the repository at this point in the history

  39. Add EXPERIMENTAL to artifact name

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e75157d View commit details
    Browse the repository at this point in the history

  40. Include win-64 only on release 

    - Matrix build job uses new output paradigm
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    acad9d5 View commit details
    Browse the repository at this point in the history

  41. Add python version to job name 

    Ensure build-installers runs, even on release when build-noarch-conda-pkgs does not run
Do not download local conda package artifacts on release
    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    b5ce815 View commit details
    Browse the repository at this point in the history

  42. Update patch file

    @mrclary
    mrclary committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    cff5690 View commit details
    Browse the repository at this point in the history

  43. Apply suggestions from code review 

    Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
    @mrclary @ccordoba12
    mrclary and ccordoba12 committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ca3ebf3 View commit details
    Browse the repository at this point in the history