PR: Improve cells support in the Editor

[jsbautista]

Description of Changes

• Add a button in one of main toolbars to create a new cell.
• Add cell divider to also cross the line numbers.

Issue(s) Resolved

Part of spyder-ide/ux-improvements#30

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@jsbautista

[jsbautista]

Hi @dalthviz

[dalthviz]

Thanks @jsbautista for working on this! Checked locally and seems like is working correctly 👍 Left some initial comments to remove some imports that seem like unused, some code style issues, suggestions for the new action icon and placement.

However, seems like the tests are failing due to a missing shortcut definition. For that you will need to define a shortcut at

spyder/spyder/config/main.py

Lines 416 to 417 in 450e50d

	# ---- Editor ----
	# -- In widgets/sourcecode/codeeditor.py

(maybe Ctrl + 2 could work for the moment).

Also could you add a GIF to preview the functionality here?

Thanks!

[dalthviz]

Hi again @jsbautista , left a couple of new comments/suggestions but other than that this LGTM 👍

I think the failing test job is unrelated to the changes here but lets check if it fails again after applying the changes for the new review

[jsbautista]

Preview

[ccordoba12]

Thanks for your work on this @jsbautista! It's really nice improvement!

[ccordoba12]

@jsbautista, I think you need to merge with master to get make our Linux tests pass.

[ccordoba12]

One last thing to consider, but perhaps for a follow-up PR: should we try to move the code that paints cell dividers on top of panels to the paintEvent method of the base Panel class?

@jsbautista, @dalthviz, I don't know if you considered that before, but it could be worth the try, don't you think?

[dalthviz]

One last thing to consider, but perhaps for a follow-up PR: should we try to move the code that paints cell dividers on top of panels to the paintEvent method of the base Panel class?

I think that could be a good idea. In that way if more panels are added then they will automatically add the cell line 👍 Probably we will need to validate self.position to only apply the code to paint the cell line when the panel position is on the LEFT right @ccordoba12 ?

[ccordoba12]

In that way if more panels are added then they will automatically add the cell line +1

Yep, that was my reasoning too.

Probably we will need to validate self.position to only apply the code to paint the cell line when the panel position is on the LEFT right @ccordoba12 ?

I'd say LEFT and RIGHT, just to be safe (users could add panels to the right using our API).

[ccordoba12]

@dalthviz, @jsbautista, I think this is ready to be merged, unless you prefer to make the changes to paintEvent we talked about here too.

[dalthviz]

@jsbautista will working on the refactor mentioned above here 👍

[dalthviz]

Thanks for the refactoring @jsbautista ! Left some suggestions and a couple of comments about where the new paint_cell method is being called. Other possibility is to add to the method the option to just run the logic for a given block (otherwise seems to me that we will be calling a for inside a for with the current usage in some of the panels).

If you have any question about the feedback let me know!

[dalthviz]

Note: this needs a merge with master for the tests to pass

[ccordoba12]

Thanks @jsbautista for your work on this! I left some additional comments for you.

[ccordoba12]

Looks good to me now, thanks @jsbautista!

[dalthviz]

Thanks for all the work here @jsbautista !