Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Enable running renamed and IPython files again #20762

Merged
merged 22 commits into from
Jun 25, 2023

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Apr 2, 2023

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #20701
Fixes #20715

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@impact27 impact27 changed the title PR: Enable running renamed files PR: Enable running renamed files and .ipy files Apr 2, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27 for your work on this!

spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/editor.py Outdated Show resolved Hide resolved
spyder/plugins/pylint/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/run/plugin.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
impact27 and others added 3 commits June 22, 2023 22:44
- That's because those plugins can't run them.
- Also, transform a logging error into a debug message because there's
nothing users can do about it.
- That can happen for some rename operations.
- Also, improve some docstrings, fix minor style issues and replace the
usage of to_text_string by the str builtin.
@ccordoba12
Copy link
Member

ccordoba12 commented Jun 24, 2023

@impact27, I disabled running IPython files in the Code Analysis and External Console plugins because they can't handle that file type.

I also pushed a fix for a bug I found while testing this locally: if you renamed a Python file to an IPython one in the editor, then it was registered twice, which didn't allow to run it afterwards.

@ccordoba12 ccordoba12 changed the title PR: Enable running renamed files and .ipy files PR: Enable running renamed and IPython files Jun 24, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 changed the title PR: Enable running renamed and IPython files PR: Enable running renamed and IPython files again Jun 25, 2023
@ccordoba12 ccordoba12 merged commit f8e5290 into spyder-ide:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not run IPython files in master Can not run renamed file in master
2 participants