-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add help info widget to show tooltips in Preferences (UX/UI) #20926
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Thanks @jsbautista for your work on this! Quick feedback for you:
|
This comment was marked as outdated.
This comment was marked as outdated.
This looks really, really nice, thanks @jsbautista for your work on it! One additional suggestion according to what you posted in your last screenshot: I think tooltips should only be shown when hovering over the new help widgets, not over the options' text. That's the main purpose of these widgets, so there's no need for us to keep showing tooltips over the options themselves. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista and @dalthviz for your work on this!
spyder/plugins/completion/providers/languageserver/conftabs/advanced.py
Outdated
Show resolved
Hide resolved
spyder/plugins/completion/providers/languageserver/conftabs/formatting.py
Outdated
Show resolved
Hide resolved
spyder/plugins/completion/providers/languageserver/conftabs/introspection.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista and @dalthviz for your work on this!
The Plugins section in the preferences dialog allows to enable/disable plugins. After making changes and pressing OK or Apply in the preferences dialog, an error occurred. The error occurs because of a change of the return type of SpyderConfigPage.create_checkbox() (see PR20926 [1]). [1] spyder-ide#20926
The Plugins section in the preferences dialog allows to enable/disable plugins. After making changes and pressing OK or Apply in the preferences dialog, an error occurred. The error occurs because of a change of the return type of SpyderConfigPage.create_checkbox() (see PR20926 [1]). [1] spyder-ide#20926
* Return value of `.create_checkbox()` changed in spyder-ide/spyder#20926 (Show tooltips in Preferences). * Handling of Prefs dialog box size changed in spyder-ide/spyder#21233 (Improve style of Preferences dialog box).
Description of Changes
Method to add help label in each preferences widget that has a tooltip definition
Preview
Issue(s) Resolved
Part of spyder-ide/ux-improvements#75 (spyder-ide/ux-improvements#75 (comment))
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@jsbautista