Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add help info widget to show tooltips in Preferences (UX/UI) #20926

Merged
merged 27 commits into from
Jul 18, 2023

Conversation

jsbautista
Copy link
Contributor

@jsbautista jsbautista commented May 15, 2023

Description of Changes

Method to add help label in each preferences widget that has a tooltip definition

Preview

preferences

Issue(s) Resolved

Part of spyder-ide/ux-improvements#75 (spyder-ide/ux-improvements#75 (comment))

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@jsbautista

@jsbautista

This comment was marked as outdated.

@ccordoba12
Copy link
Member

Thanks @jsbautista for your work on this! Quick feedback for you:

@jsbautista jsbautista changed the title [WIP] PR: Add help button in each preferences widget PR: Add help button in each preferences widget May 29, 2023
@jsbautista

This comment was marked as outdated.

@ccordoba12
Copy link
Member

This looks really, really nice, thanks @jsbautista for your work on it!

One additional suggestion according to what you posted in your last screenshot: I think tooltips should only be shown when hovering over the new help widgets, not over the options' text.

That's the main purpose of these widgets, so there's no need for us to keep showing tooltips over the options themselves.

@jsbautista

This comment was marked as outdated.

@dalthviz

This comment was marked as outdated.

@dalthviz dalthviz self-assigned this Jul 11, 2023
@dalthviz dalthviz requested a review from ccordoba12 July 14, 2023 22:15
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista and @dalthviz for your work on this!

spyder/plugins/appearance/confpage.py Outdated Show resolved Hide resolved
spyder/plugins/editor/confpage.py Outdated Show resolved Hide resolved
spyder/plugins/preferences/api.py Show resolved Hide resolved
spyder/plugins/preferences/api.py Show resolved Hide resolved
spyder/plugins/preferences/api.py Show resolved Hide resolved
spyder/plugins/variableexplorer/confpage.py Outdated Show resolved Hide resolved
spyder/plugins/preferences/api.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Add help button in each preferences widget PR: Add help info widget to show tooltips in Preferences (UX/UI) Jul 15, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista and @dalthviz for your work on this!

@ccordoba12 ccordoba12 merged commit 8861408 into spyder-ide:master Jul 18, 2023
rear1019 added a commit to procitec/spyder that referenced this pull request Aug 9, 2023
The Plugins section in the preferences dialog allows to enable/disable
plugins. After making changes and pressing OK or Apply in the
preferences dialog, an error occurred.

The error occurs because of a change of the return type of
SpyderConfigPage.create_checkbox() (see PR20926 [1]).

[1] spyder-ide#20926
rear1019 added a commit to procitec/spyder that referenced this pull request Aug 10, 2023
The Plugins section in the preferences dialog allows to enable/disable
plugins. After making changes and pressing OK or Apply in the
preferences dialog, an error occurred.

The error occurs because of a change of the return type of
SpyderConfigPage.create_checkbox() (see PR20926 [1]).

[1] spyder-ide#20926
jitseniesen added a commit to jitseniesen/spyder-unittest that referenced this pull request Nov 7, 2023
* Return value of `.create_checkbox()` changed in spyder-ide/spyder#20926
  (Show tooltips in Preferences).
* Handling of Prefs dialog box size changed in spyder-ide/spyder#21233
  (Improve style of Preferences dialog box).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants