PR: Prevent error when updating sys.path in consoles (IPython console)
#22490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
reviewed
Sep 16, 2024
| if self.kernel_handler is not None: | ||
| self.call_kernel(interrupt=True, blocking=False).update_syspath( | ||
| path_dict, new_path_dict | ||
| ) |
There was a problem hiding this comment.
Shouldn't the sys.path contents that was updated be saved somewhere to properly apply it when kernel_handler is available? Or maybe there is no possiblitiy that at some point later on the kernel_handler becomes available?
There was a problem hiding this comment.
I thought about that and concluded it's not necessary because this error can only happen when the kernel is not available (because it errored at startup or the Spyder-kernels version is wrong).
|
@meeseeksdev please backport to 6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/spyder
that referenced
this pull request
Sep 17, 2024
…th` in consoles (IPython console)
dalthviz
added a commit
that referenced
this pull request
Sep 18, 2024
…490-on-6.x Backport PR #22490 on branch 6.x (PR: Prevent error when updating `sys.path` in consoles (IPython console))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This happened when the kernel was not available and users opened/closed projects or used the Python path manager.
Issue(s) Resolved
Fixes #21563.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: