Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add initial tests for the Remote client plugin #22527

Merged
merged 30 commits into from
Oct 8, 2024

Conversation

hlouzada
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Add fixtures to start an ssh server docker, start the remote client and ipythonconsole plugins, and register the remote server to be used.
Add plugin's tests with start/stop/restart kernels;
Add ipythonconsole test to start/stop/restart/kill kernels;

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @hlouzada

@hlouzada hlouzada changed the title PR: Add initial tests for remote client [WIP] PR: Add initial tests for remote client Sep 18, 2024
@pep8speaks
Copy link

pep8speaks commented Sep 25, 2024

Hello @hlouzada! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-07 16:56:50 UTC

@hlouzada hlouzada changed the title [WIP] PR: Add initial tests for remote client PR: Add initial tests for remote client Sep 25, 2024
@hlouzada hlouzada marked this pull request as ready for review September 27, 2024 19:01
@hlouzada hlouzada force-pushed the feat-remoteclient-tests branch from bb5e7d1 to 0380a6b Compare September 30, 2024 20:39
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @hlouzada!

Just some small suggestions for you.

.github/workflows/test-remoteclient.yml Outdated Show resolved Hide resolved
.github/workflows/test-remoteclient.yml Outdated Show resolved Hide resolved
.github/workflows/test-remoteclient.yml Outdated Show resolved Hide resolved
.github/workflows/test-remoteclient.yml Show resolved Hide resolved
spyder/config/base.py Outdated Show resolved Hide resolved
spyder/config/base.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/__init__.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
.github/workflows/test-remoteclient.yml Outdated Show resolved Hide resolved
.github/scripts/run_tests.sh Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v6.0.2 milestone Sep 30, 2024
@hlouzada hlouzada force-pushed the feat-remoteclient-tests branch from be64158 to dd89fc7 Compare September 30, 2024 23:27
@hlouzada hlouzada force-pushed the feat-remoteclient-tests branch from 92af82e to c44f8ab Compare September 30, 2024 23:56
@ccordoba12 ccordoba12 changed the title PR: Add initial tests for remote client PR: Add initial tests for the remote client Oct 1, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hlouzada for your work on this!

runtests.py Outdated Show resolved Hide resolved
spyder/config/base.py Show resolved Hide resolved
spyder/config/base.py Show resolved Hide resolved
spyder/plugins/remoteclient/tests/conftest.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/tests/conftest.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/tests/conftest.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/tests/conftest.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/tests/conftest.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/tests/conftest.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @hlouzada!

Note: I merged your PR with master in my last commit to fix the merge conflict that showed up after PR #22642.

@ccordoba12 ccordoba12 merged commit bb59134 into spyder-ide:master Oct 8, 2024
17 checks passed
ccordoba12 added a commit to ccordoba12/spyder that referenced this pull request Oct 8, 2024
@ccordoba12 ccordoba12 changed the title PR: Add initial tests for the remote client PR: Add initial tests for the Remote client plugin Oct 8, 2024
ccordoba12 added a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants