Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Don't hide control debugger buttons from main toolbar while executing #23273

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

athompson673
Copy link
Contributor

while debugging, clicking run (step in/out, etc) causes the debug actions on the toolbar to briefly hide until the current line has completed. This looks visually glitchy, and can cause mis-clicks. Instead continue to show the buttons if currently executing.

Issue(s) Resolved

Fixes #23208

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: athompson673

@athompson673 athompson673 changed the title don't hide pdb actions while executing PR: don't hide pdb actions while executing Dec 13, 2024
@athompson673 athompson673 changed the title PR: don't hide pdb actions while executing PR: Don't hide pdb actions while executing Dec 13, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion for you @athompson673, the rest looks good to me.

spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Don't hide pdb actions while executing PR: Don't hide control debugger buttons from main toolbar while executing Dec 15, 2024
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
@athompson673
Copy link
Contributor Author

One tiny suggestion for you @athompson673, the rest looks good to me.

LGTM, ship it

@athompson673
Copy link
Contributor Author

oops wrong button

@ccordoba12 ccordoba12 added this to the v6.0.4 milestone Dec 15, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @athompson673!

@ccordoba12 ccordoba12 merged commit 49e81ef into spyder-ide:master Dec 15, 2024
17 of 34 checks passed
@ccordoba12
Copy link
Member

@meeseeksdev please backport to 6.x

meeseeksmachine pushed a commit to meeseeksmachine/spyder that referenced this pull request Dec 15, 2024
ccordoba12 pushed a commit that referenced this pull request Dec 15, 2024
@athompson673 athompson673 deleted the patch-2 branch December 16, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The control debugger buttons are hidden from the main toolbar when code is executed
2 participants