Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add missing __init__() calls #23324

Closed
wants to merge 1 commit into from

Conversation

rear1019
Copy link
Contributor

Description of Changes

Add missing __init__() calls detected with PySide2. I have no idea why it works with PyQt5 and PyQt6.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

rear1019

@rear1019 rear1019 marked this pull request as ready for review December 20, 2024 14:16
@ccordoba12 ccordoba12 added this to the v6.0.4 milestone Dec 20, 2024
@ccordoba12 ccordoba12 changed the title PR: Add missing __init__() calls PR: Add missing __init__() calls Dec 20, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @rear1019!

@ccordoba12 ccordoba12 changed the base branch from 6.x to master December 20, 2024 16:59
@ccordoba12 ccordoba12 changed the base branch from master to 6.x December 20, 2024 16:59
@ccordoba12
Copy link
Member

@rear1019, I just noticed that you created this PR against 6.x, which is not really necessary. Now all PRs have to be done against master. After they are merged, we backport the ones that correspond to bugfixes or minor features to the 6.x branch with a bot.

So, please recreate this PR against master.

@ccordoba12 ccordoba12 closed this Dec 20, 2024
@ccordoba12 ccordoba12 removed this from the v6.0.4 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants