Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request may not have attr exception #109

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

Germey
Copy link
Contributor

@Germey Germey commented May 5, 2017

request may not have attr exception, I've tested for many times.

if request doesn't have exception attr, it will not call exception_handler, and at this time, response is none, so you don't know where to handle this situation.

So although request doesn't have exception attr, you can still call exception handler, so you can handle this situation by judgeing request's attrs.

@spyoungtech
Copy link
Owner

Thank you for this contribution @Germey and apologies for the very long delay in getting this addressed.

This makes perfect sense to me. If there is no response, clearly it's an exceptional case and the exception handler should have an opportunity to handle it, even if the exception attr doesn't exist.

I'll go ahead and merge this in and release a new version Though, I am curious if you have any example of how the issue can be reproduced so that tests can be added.

Thanks again!

@spyoungtech spyoungtech merged commit 698fac9 into spyoungtech:master Apr 2, 2020
@Germey
Copy link
Contributor Author

Germey commented Apr 2, 2020

Thanks for your merging. But I forgot the example because of so long time. If I have similar case, I'll send it back to you. Hopes well, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants