close session if it won't be reused #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #137 grequests holds onto memory if the session is not closed. Other issues can also be caused by creating (and never closing) many session objects. Also relates to #115
This solution will close the session if a session object is not provided by the user. If the user does provide a session object, we don't close it, otherwise the user may lose some benefits of using a single session object and its connection pool. If a user provides a session object, it also addresses the memory build up, since we don't create a session in that case.