Hoist constants from Sqids.Builder to Sqids #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhanlon22
force-pushed
the
hoist-constants
branch
from
c41108c to
4c51ad8
Compare
Since Sqids.Builder doesn't do anything with these constants behavior-wise, it makes sense to me to hoist the constants to Sqids so they're easier to see. Since these constants are now in the top-level Sqids class, I've also made Sqids.Builder package-private since it's not meant to be instantiated directly. .gitignore has also been updated to ignore the .project file that was generated by my dev environment.
robhanlon22
force-pushed
the
hoist-constants
branch
from
4c51ad8 to
9ce4428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Sqids.Builder doesn't do anything with these constants behavior-wise, it makes sense to me to hoist the constants to Sqids so they're easier to see. Since these constants are now in the top-level Sqids class, I've also made Sqids.Builder package-private since it's not meant to be instantiated directly.
I also added a few things to the .gitignore that showed up in my coding environment.