Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error-handling in worker #288

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Conversation

bryangingechen
Copy link
Contributor

This is a first attempt at addressing part 2 of #279, which points out that errors in the worker builds are not caught.

@ShashkovS
Copy link

This also fix error handling in case of syntax error.
Just run request seERRORlect * from table and exception will be lost.
It is because throw in promises works a little bit strange if it is not catched.
https://stackoverflow.com/questions/30715367/why-can-i-not-throw-inside-a-promise-catch-handler
https://stackoverflow.com/questions/39992417/how-to-bubble-a-web-worker-error-in-a-promise-via-worker-onerror

@bryangingechen
Copy link
Contributor Author

@lovasoa Any comments on this?

@lovasoa
Copy link
Member

lovasoa commented Jan 10, 2020

Sorry for not taking care of this earlier. This looks good to me.

@lovasoa lovasoa merged commit b233e61 into sql-js:master Jan 10, 2020
@bryangingechen bryangingechen deleted the worker-errors branch January 10, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants