- remove -DLONGDOUBLE_TYPE=double from Makefile
#381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizhu256
force-pushed
the
fix-long-double-issue
branch
from
1de9f69
to
9097504
Compare
lovasoa
requested changes
Apr 4, 2020
2 tasks
|
please wait for merge, adding one more commit to test for infinity upper-bound |
lovasoa
requested changes
Apr 4, 2020
lovasoa
requested changes
Apr 4, 2020
- update test to include CAST(1.7976931348623157e+308 AS REAL) - add test-case to verify infinity upper-bound - Co-authored-by: Christopher J. Brody <chris.brody at gmail.com>
kaizhu256
force-pushed
the
fix-long-double-issue
branch
from
6418ae7
to
4a63519
Compare
lovasoa
requested changes
Apr 4, 2020
|
Thanks to @kaizhu256 for taking care of this and for getting it right! I noticed that GitHub does not detect me as co-author, I think it is because the line starts with a dash. Nothing major but maybe something to watch for in the future. Again 🍾 🎉 thanks! |
|
Sorry about the credits @brodybits ^^;;; |
lovasoa
added a commit
that referenced
this pull request
Apr 5, 2020
niurkacanals
added a commit
to niurkacanals/Dev-container-sql
that referenced
this pull request
Sep 2, 2022
brendasmith8
pushed a commit
to brendasmith8/sql-database-server-develop
that referenced
this pull request
Sep 22, 2022
bestreviewsbookssoftware08
added a commit
to bestreviewsbookssoftware08/sql.js
that referenced
this pull request
Aug 25, 2024
topoftheblog33
added a commit
to topoftheblog33/sql.js
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an updated fix for pull-request #337 . included @brodybits as co-author in commit-message.
this pull-request resolves issue #325 by verifying the following test-cases:
SELECT 1.7976931348623157e+308evaluates to 1.7976931348623157e+308 (instead of Infinity)SELECT ?evaluates to 1.7976931348623157e+308 (instead of Infinity)SELECT CAST('1.7976931348623157e+308' AS REAL)evaluates to 1.7976931348623157e+308 (instead of Infinity)if this pull-request is ok to merge, please close #337 and close #325 as well.