Upgrade to Emscripten 2.0.29 #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the chance that another dev will forget to do this.
Changes required: * Defined EM_NODE_JS environment variable to get rid of a warning that appears if the NODE environment variable is set, but EM_NODE_JS is not. * EXTRA_EXPORTED_RUNTIME_METHODS is now EXPORTED_RUNTIME_METHODS * No longer pass the `-s LINKABLE=1` option to emcc when compiling. (This is a linktime setting and emcc warns about not using a linktime setting when compiling now).
lovasoa
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this is a good idea to periodically do this or not, but it did expose a couple of surprising compile-time warnings that took me a while to work out, so I think there is value in it.
Note that I built this on top of my work in my other PR #476, so that
npm cicommit will disappear from this diff when that's merged. (I rarely work on open source projects, so I'm not sure the best way to more easily capture stacking PRs like this when the branch I'm stacking on top of doesn't exist in the target repo).It's worth noting that the compiled files appear to be smaller. (Emscripted 2.0.29 on the left. Latest release of sql.js on the right).
The only testing I've done is the
npm test. I don't know if we need a more in-depth test suite and/or a performance test suite for these sorts of changes.