-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the unique flag in DropIndexOp
#1372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 5d6616c of this pull request into gerrit so we can run tests and reviews and stuff
New Gerrit review created for change 5d6616c: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4995 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 515b4ed of this pull request into gerrit so we can run tests and reviews and stuff
Patchset 515b4ed added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4995 |
:tickets: 1370 | ||
|
||
Fixed issue with downgrade migration of unique indexes autogenerating | ||
non-unique indexes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add "pull request courtesy of you" if you like
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4995 has been merged. Congratulations! :) |
Description
Fix #1371
Keep the unique flag in the index generated by
DropIndexOp.from_index(...)
.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit messageHave a nice day!