Add tails.com flow #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiallRees
reviewed
Feb 17, 2022
| # NOTE: It's best to keep this fixed to a version for stability, and this | ||
| # flow requires at least 0.10.1. Do update to a later versions as they are released. | ||
| sqlfluff==0.10.1 | ||
| sqlfluff-templater-dbt==0.10.1 |
There was a problem hiding this comment.
Would recommend just using dbt-snowflake~=1.0.0 and sqlfluff-templater-dbt==0.10.1, and adding those to the tox.ini deps
There was a problem hiding this comment.
Agreed on stripping the other deps. Why add them to the tox file? That's not what gets called to set up the environment.
@NiallRees - can you clarify what you mean?
I wonder if using a tox.ini file here is distracting because it's only really being used as a .sqlfluff file.
NiallRees
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've finally set up a good robust github action flow on the tails.com dbt project.
This documents our flow, which is heavily inspired by the surfline flow. Based on input from @NiallRees I'm posting this as a new flow but with many links back to the surfline version.
This solves the problem of #15 by using the new
--write-outputoption released in sqlfluff 0.10.1.Feedback very welcome!