Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further fix for L036 #1428

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Noticed I wasn't getting 100% pytest coverage, which looks to be due to #1427. Weird though as Coverage didn't flag this this.

Anyway, addressing that flagged another (admittedly obscure!) edge case - comments BEFORE columns (I mean - who does that!?!?). So added the test case and the support for that.

Note I also fixed some typos in the CHANGELOG.

Are there any other side effects of this change that we should be aware of?

Nope. Pretty obscure edge case, and added a test case for it.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/parser (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #1428 (13bed6e) into main (ce4e5a3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1428   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          127       127           
  Lines         8603      8639   +36     
=========================================
+ Hits          8603      8639   +36     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_postgres.py 100.00% <100.00%> (ø)
src/sqlfluff/rules/L036.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97975b0...13bed6e. Read the comment docs.

@barrywhart barrywhart merged commit 250fe28 into sqlfluff:main Sep 21, 2021
@tunetheweb tunetheweb deleted the further-fix-for-l036 branch June 23, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants