Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support of MySQL CREATE TABLE TIMESTAMP/DATESTAMP #1530

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #1526

Are there any other side effects of this change that we should be aware of?

Nope, standard dialect enhancement

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/parser (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1530 (911251d) into main (46188cf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1530   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          131       131           
  Lines         9180      9184    +4     
=========================================
+ Hits          9180      9184    +4     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_postgres.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_mysql.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b63c4...911251d. Read the comment docs.

@tunetheweb tunetheweb merged commit d0a01f2 into sqlfluff:main Oct 6, 2021
@tunetheweb tunetheweb deleted the mysql-better-create-table-timestamp-support branch October 6, 2021 22:28
@alanmcruickshank alanmcruickshank mentioned this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does SQLFluff support MySQLs DEFAULT CURRENT_TIMESTAMP?
2 participants