Increase minimum runs before coverage report is issued #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1596 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9175 9175
=========================================
Hits 9175 9175 Continue to review full report at Codecov.
|
barrywhart
approved these changes
Oct 11, 2021
|
Upped it to 10. Seems like the Windows one needs to complete and it's often the slowest (though only by a minute or two). |
ttomasz
pushed a commit
to ttomasz/sqlfluff
that referenced
this pull request
Oct 12, 2021
* Increase minimum runs for coverage checks * Update to 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Noticed codecov is triggering too early. Seems like the Windows run (which is often the last to complete) is needed. Let's just insist on all the tests completing.
Are there any other side effects of this change that we should be aware of?
Nope.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/parser(note YML files can be auto generated withpython test/generate_parse_fixture_yml.pyor by runningtoxlocally).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.