Teradata: Added date as bare function

[anzelpwj]

Brief summary of the change made

Fixes #1611 . I've added DATE as a bare function (line 89).

Are there any other side effects of this change that we should be aware of?

I also removed it from unreserved and reserved keywords - please let me know if this an incorrect change and I can adjust as necessary.

Pull Request checklist

• Please confirm you have completed any of the necessary steps below.

• Included test cases to demonstrate any code changes, which may be one or more of the following:

  • .yml rule test cases in test/fixtures/rules/std_rule_cases.
  • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
  • Full autofix test cases in test/fixtures/linter/autofix.
  • Other.

• Added appropriate documentation for the change.

• Created GitHub issues for any relevant followup/future enhancements if appropriate.

[tunetheweb]

change looks good. But some requests for the test cases if you could have a look?

[tunetheweb]

Nit, but could you add a new line to the end of the file? We have an editorconfig file if your editor supports that (most of them do) to enforce that without you having too.

Also are there any other examples we could use here? Can DATE be used with any params? If so could you add another example or two? Remember to regenerate the YAML after.

[anzelpwj]

Will do.

[anzelpwj]

SELECT DATE (FORMAT 'MMMbdd,bYYYY') (CHAR(12), UC); from the docs doesn't parse.

[tunetheweb]

What about:

SELECT DATE (FORMAT 'MMMbdd,bYYYY') 

for now? Could do the next (casting?) bit at another time. Unless you wanna figure out how to do that now to as part of this PR?

[anzelpwj]

Specifically, it doesn't like the (CHAR(12), UC) bit - this might be something to address in a different MR.

[anzelpwj]

#1665

[codecov]

Codecov Report

Merging #1663 (7c937e5) into main (ec7c2dd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1663   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines         9316      9317    +1     
=========================================
+ Hits          9316      9317    +1     

Impacted Files	Coverage Δ
src/sqlfluff/dialects/dialect_teradata.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7c2dd...7c937e5. Read the comment docs.

[tunetheweb]

Thanks for those other test case. They aren’t parsing as bare_functions but that’s fine (they aren’t bare functions!), but think good to have none the less.

If tests pass we can approve and merge.

[anzelpwj]

Do I need to update changelog, contributors, etc?

[tunetheweb]

Nope. All automatic. See #1287 and #1295

[tunetheweb]

First PR to the project. Woo hoo and thanks!!

[anzelpwj]

Hooray! Thanks for the help!