Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DROP TYPE statement in postgres dialect #1870

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Add DROP TYPE statement in postgres dialect #1870

merged 3 commits into from
Nov 10, 2021

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Nov 9, 2021

Brief summary of the change made

Fixes #1836. I have added the full implementation of the grammar from the postgres documentation (https://www.postgresql.org/docs/14/sql-droptype.html). I have added a variety of test cases to fully test the grammar.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1870 (a023951) into main (fbf53ef) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1870   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          139       139           
  Lines         9866      9870    +4     
=========================================
+ Hits          9866      9870    +4     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_postgres.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf53ef...a023951. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres: Lint: DROP TYPE unparsable
2 participants