Move package metadata to setup.cfg #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpy-git
commented
Nov 22, 2021
There was a problem hiding this comment.
@barrywhart could you take a look at this when you get a chance please? Hoping to build off of it in the docker PR #1945, Thanks! 😄
Codecov Report
@@ Coverage Diff @@
## main #1960 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 147 147
Lines 10279 10279
=========================================
Hits 10279 10279 Continue to review full report at Codecov.
|
barrywhart
reviewed
Nov 23, 2021
barrywhart
approved these changes
Nov 23, 2021
This was referenced Nov 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
This PR is a straight swap from
setup.pyto declarative metadata insetup.cfg. Simplifies the setup file and makes it easier for tools to extract the package metadata (e.g. extracting requirements for use in the docker build #1945).Are there any other side effects of this change that we should be aware of?
No, exactly the same but uses declarative metadata.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withpython test/generate_parse_fixture_yml.pyor by runningtoxlocally).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.