Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit: Add hook for doc8 #2074

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Pre-commit: Add hook for doc8 #2074

merged 1 commit into from
Dec 8, 2021

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Dec 8, 2021

Brief summary of the change made

Follow up PR to #2067. Adds a pre-commit hook to also run our doc linting at commit time.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@jpy-git
Copy link
Contributor Author

jpy-git commented Dec 8, 2021

@barrywhart pre-commit checks for docs

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #2074 (e49e120) into main (3539a19) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2074   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines        10538     10538           
=========================================
  Hits         10538     10538           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3539a19...e49e120. Read the comment docs.

@jpy-git jpy-git merged commit fc486d1 into sqlfluff:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants