Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code formatting in Rule docs #2418

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Noticed a load of sty code formatting marks in rule docs due to bad markup.

image

image

image

Are there any other side effects of this change that we should be aware of?

Nope

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@tunetheweb tunetheweb requested review from jpy-git and barrywhart and removed request for jpy-git January 22, 2022 12:01
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #2418 (47fe4d1) into main (0dbc5ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2418   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         162      162           
  Lines       11561    11561           
=======================================
  Hits        11553    11553           
  Misses          8        8           
Impacted Files Coverage Δ
src/sqlfluff/rules/L041.py 100.00% <ø> (ø)
src/sqlfluff/rules/L043.py 100.00% <ø> (ø)
src/sqlfluff/rules/L047.py 100.00% <ø> (ø)
src/sqlfluff/rules/L056.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbc5ed...47fe4d1. Read the comment docs.

Copy link
Contributor

@jpy-git jpy-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the docs and looks good! 👍 LGTM 🚀 ✨

@jpy-git jpy-git merged commit f1dba0e into sqlfluff:main Jan 22, 2022
@tunetheweb tunetheweb deleted the fix-rule-docs branch June 23, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants