Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BigQuery typeless STRUCTs Expressions #2435

Merged
merged 4 commits into from
Jan 23, 2022

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #1913

This makes BigQiery STRUCT statements full expressions so they can be used everywhere, rather than an add-on that can only be used in some places.

Are there any other side effects of this change that we should be aware of?

Adds the struct type to ANSI (as Nothing) to allow it to be part of Expression C and then overridden in BigQuery.
Cleans up some other references to TypelessStructSegment as no longer needs to be directly referenced as now can be referenced through an Expression.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #2435 (1eb5b52) into main (6ccaaa9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2435   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          162       162           
  Lines        11571     11571           
=========================================
  Hits         11571     11571           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <100.00%> (ø)
src/sqlfluff/dialects/dialect_bigquery.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ccaaa9...1eb5b52. Read the comment docs.

Copy link
Member

@barrywhart barrywhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Very nice cleanup!

@tunetheweb tunetheweb merged commit 21b4ac6 into sqlfluff:main Jan 23, 2022
@tunetheweb tunetheweb deleted the bigquery-struct-expressions branch June 23, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery parser cannot handle structs within an IF clause
2 participants