Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update click version requirement in setup.cfg to match that in requirements.txt #2518

Merged

Conversation

barrywhart
Copy link
Member

@barrywhart barrywhart commented Jan 30, 2022

Brief summary of the change made

Fixes #2519

Address the Megalinter issue discussed here: https://sqlfluff.slack.com/archives/C01GX4L213J/p1643566502596369. The issue was, the required version of click needed to be newer in order to ensure that the click.shell_completion module was present.

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@barrywhart barrywhart requested a review from tunetheweb January 30, 2022 19:18
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #2518 (99e1209) into main (4c95ee5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          162       162           
  Lines        11696     11696           
=========================================
  Hits         11696     11696           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c95ee5...99e1209. Read the comment docs.

@barrywhart barrywhart merged commit 5a604de into sqlfluff:main Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'click.shell_completion' install errors
2 participants