Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark3: Support for SORT BY Clause #2651

Merged
merged 7 commits into from
Feb 15, 2022

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Feb 15, 2022

Brief summary of the change made

Create SortByClauseSegment to allow for parsing of SORT BY clause. OrderByClauseSegment in Ansi was used with minor changes

Are there any other side effects of this change that we should be aware of?

Found #2650 while working on this. I excluded the rule for linting while testing.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #2651 (7a1c93f) into main (049f912) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2651   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        11995     12000    +5     
=========================================
+ Hits         11995     12000    +5     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_spark3.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 049f912...7a1c93f. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

src/sqlfluff/dialects/dialect_spark3.py Outdated Show resolved Hide resolved
@tunetheweb tunetheweb merged commit 67116c8 into sqlfluff:main Feb 15, 2022
@tunetheweb tunetheweb changed the title Sark3: Support for SORT BY Clause Spark3: Support for SORT BY Clause Feb 15, 2022
@R7L208 R7L208 deleted the r7l208/spark3-sort-by-clause branch August 30, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants